Lucas_Werkmeister_WMDE added a comment.
In T339111#8949436 <https://phabricator.wikimedia.org/T339111#8949436>, @Lucas_Werkmeister_WMDE wrote: >> It’s not a Mustache template, it’s a Wikibase-specific thing, predating Mustache support in core by a few years. (It’s actually implemented based on `Message`, but bypassing almost all `Message` functionality – AFAICT there’s little reason why we don’t just replace `$1`, `$2` etc. directly.) Replacing it with Mustache might be a good idea (we need to process these templates server- and client-side, and MediaWiki gives us that), but that should be done outside of a security task. > > I put together a quick proof of concept for decoupling Wikibase’s `Template` class from core’s `Message`, and it seems to work well enough in local testing. I’ll push it for CI checks once this task is public. (Migrating to Mustache needs a bit more work because it’ll require updating all the templates.) ⇒ POC: Decouple Template from Message <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/935001> TASK DETAIL https://phabricator.wikimedia.org/T339111 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mstyles, Lucas_Werkmeister_WMDE Cc: Mstyles, gerritbot, Tarrow, lojo_wmde, adee_wmde, roti_WMDE, Tobi_WMDE_SW, daniel, Krinkle, thiemowmde, sbassett, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Arian_Bozorg, Aklapper, Michael, Cleo_Lemoisson, Astuthiodit_1, karapayneWMDE, Invadibot, Dylsss, Devnull, maantietaja, Y.ssk, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, Grunny, He7d3r, csteipp, Mbch331, Jay8g, Krenair, Legoktm
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
