Lucas_Werkmeister_WMDE added a comment.
Meh, that alone doesn’t work, there’s some strange error in another test (console <https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/114939/console>): counterexample 1) EntitySchema\Tests\Integration\MediaWiki\Content\EntitySchemaSlotDiffRendererTest::testGetDiff with data set "changes, removals and additions" (array(array('test label'), array('test description'), array(array('test alias', 'test alias 2')), 'test schema', 'ShExC', '3.0'), array(array('updated label'), array('Testbeschreibung'), array(array('test alias', 'test alias 3'), array('Testalias')), 'schema updated', '3.0'), '<tr>\n <td colspan="2" class=...n</tr>') TypeError: Return value of TextSlotDiffRenderer::getTextDiffer() must implement interface MediaWiki\Diff\TextDiffer\TextDiffer, null returned /workspace/src/includes/diff/TextSlotDiffRenderer.php:200 /workspace/src/includes/diff/TextSlotDiffRenderer.php:324 /workspace/src/includes/diff/TextSlotDiffRenderer.php:277 /workspace/src/includes/diff/TextSlotDiffRenderer.php:305 /workspace/src/extensions/EntitySchema/src/MediaWiki/Content/EntitySchemaSlotDiffRenderer.php:159 /workspace/src/extensions/EntitySchema/src/MediaWiki/Content/EntitySchemaSlotDiffRenderer.php:102 /workspace/src/extensions/EntitySchema/src/MediaWiki/Content/EntitySchemaSlotDiffRenderer.php:75 /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Content/EntitySchemaSlotDiffRendererTest.php:182 TASK DETAIL https://phabricator.wikimedia.org/T342209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: TheresNoTime, Aklapper, Lucas_Werkmeister_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, KSiebert, Biggs657, karapayneWMDE, NRodriguez, Invadibot, STei-WMF, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, HMonroy, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, dmaza, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, B20180, _jensen, rosalieper, Neuronton, Scott_WUaS, Samwilson, MisterSynergy, Nakon, abian, MusikAnimal, Wikidata-bugs, aude, Ricordisamoa, -jem-, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Krenair
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
