Lucas_Werkmeister_WMDE added a comment.

  We should probably get the language to use from the given `FormatterOptions`, 
and expect those options to contain `ValueFormatter::OPT_LANG` or 
`FormatterLabelDescriptionLookupFactory::OPT_LANGUAGE_FALLBACK_CHAIN`, like we 
did for T281726: Stop injecting LanguageNameLookup into 
WikibaseValueFormatterBuilders <https://phabricator.wikimedia.org/T281726>. 
(Perhaps we could turn 
`WikibaseValueFormatterBuilders::newLanguageNameLookup()` into 
`LanguageNameLookupFactory::newForFormatterOptions()`? Not sure if that makes 
sense.)

TASK DETAIL
  https://phabricator.wikimedia.org/T281799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to