Nikki added a comment.

  In T135871#8055585 <https://phabricator.wikimedia.org/T135871#8055585>, 
@Manuel wrote:
  
  > Hi @Nikki, I have removed the following case that originally came from 
T267131 <https://phabricator.wikimedia.org/T267131>:
  >
  >> - Make any change to the language currently set as the interface language, 
no save needed.
  >> - The heading updates immediately, no longer applying language fallback
  >
  > My reason is that the interface language is likely factored in by design. 
The problematic part as I see it is that language fallback doesn't come back 
after one cancels the action (should be fully covered by case B). Please let me 
know in case you have any objections.
  
  I only just saw this comment (I still haven't worked out how to get 
Phabricator's notification system to do anything useful) but I don't think it 
should have been removed, for two reasons:
  
  - I don't think the page title should be updated while editing, because the 
changes haven't actually been saved and I find that misleading and unhelpful. 
When looking at my open tabs (the main reason I look at page titles), I can't 
tell which ones are using the actual label and which are showing an unsaved 
edit that will be lost I close the browser/tab without saving. If I do close 
the tab without saving, it will be saved in the tab history with a page title 
based on a label it never had.
  - If that behaviour is kept anyway, language fallback should be applied when 
editing //and// after saving/cancelling (which is not clear from the current 
description). It's weird if it shows "English label" before editing, "Q12345" 
after you type something in the description field (because there's no label in 
your current interface language) and then "English label" again after 
saving/cancelling.

TASK DETAIL
  https://phabricator.wikimedia.org/T135871

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Lucas_Werkmeister_WMDE, Manuel, Jan_Dittrich, Lydia_Pintscher, daniel, 
Glorian_Yapinus, Nikki, Aklapper, Zppix, adrianheine, Danny_Benjafield_WMDE, 
Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, 
EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, DannyS712, 
Nandana, lucamauri, Mh-3110, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, 
QZanden, enigmaeth, rohitt, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to