Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Shape Expressions, ci-test-error (WMF-deployed Build Failure). Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Since the `\IDatabase` aliases for `\Wikimedia\Rdbms\IDatabase` was removed (T344536 <https://phabricator.wikimedia.org/T344536>), two tests in EntitySchema are failing (build <https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/122649/console>): counterexample 1) EntitySchema\Tests\Integration\MediaWiki\Actions\RestoreSubmitActionTest::testRestoreSubmit Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'abc' +'def' /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Actions/RestoreSubmitActionTest.php:72 2) EntitySchema\Tests\Integration\MediaWiki\Actions\RestoreViewActionTest::testRestoreView Failed asserting that '<div class="mw-message-box cdx-message cdx-message--block mw-message-box-error cdx-message--error"><span class="cdx-message__icon"></span><div class="cdx-message__content">The revision you tried to restore is identical to the current revision. Nothing to do.</div></div><p id="mw-returnto">Return to <a href="/index.php/EntitySchema:E1234" title="EntitySchema:E1234">EntitySchema:E1234</a>.</p>\n ' contains "<ins class="diffchange diffchange-inline">abc</ins>". /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Actions/RestoreViewActionTest.php:82 We need to figure out how to fix these tests; if we can’t figure it out, we should temporarily restore the `\IDatabase` alias to fix CI. TASK DETAIL https://phabricator.wikimedia.org/T345164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
