Thompsonbry.systap added a comment.

One of the questions I had is why would #1021 not have caught this problem.

So, #1021 only protects against a call to abort() that fails. If there is a 
write set and

- (a) a failed commit where the code does not then go on to invoke abort()

-or-

(b) the code simply leaves the scope in which the write set was applied without 
either committing or aborting then we can have a situation in which buffered 
writes eventually become durable.

In #1026, the situation was (a). The mutations were not correctly discarded 
since abort() was not called. This lead to the same symptoms as per this ticket.

We will look for ways to improve protection against this circumstance and test 
coverage around such abnormal code paths.

See #1206 SPARQL UPDATE with runtime errors causes problems with lexicon 
indices (similar symptom)
See #1021 Add critical section protection to AbstractJournal?.abort() and 
BigdataSailConnection?.rollback()


TASK DETAIL
  https://phabricator.wikimedia.org/T97468

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Thompsonbry.systap
Cc: JanZerebecki, Jdouglas, Beebs.systap, Thompsonbry.systap, Thompsonbry, 
Haasepeter, Manybubbles, Aklapper, Smalyshev, jkroll, Wikidata-bugs, aude, 
daniel



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to