Tacsipacsi added a comment.
In T347578#9207898 <https://phabricator.wikimedia.org/T347578#9207898>, @matmarex wrote: > So… maybe the styling (which looked wrong to @michael above :) ) isn't actually intended, just happening by accident when the page content is displayed below the diff? Given that it’s set in a method named `setDiffPageTitle` (see T347578#9206634 <https://phabricator.wikimedia.org/T347578#9206634>), it’s obviously quite intended that it appears on diffs with `diffonly=0`. The accidental thing is that it //doesn’t// appear on diffs with `diffonly=1` – if I understand the code correctly, the data it uses is set in an OutputPageParserOutput hook <https://www.mediawiki.org/wiki/Manual:Hooks/OutputPageParserOutput> handler, which seems not to run with `diffonly=1` (which sounds right on core’s side, why would the hook run if there’s no parsed content on the page?). TASK DETAIL https://phabricator.wikimedia.org/T347578 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tacsipacsi Cc: Tacsipacsi, TheresNoTime, IKhitron, Wotheina, matmarex, Ammarpad, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
