Umherirrender added a comment.
In T346519#9182060 <https://phabricator.wikimedia.org/T346519#9182060>, @Lucas_Werkmeister_WMDE wrote: >> Use hook handlers for Wikibase hooks (T338452 <https://phabricator.wikimedia.org/T338452>) - (this point is stalled, hook interface are not implement yet) > > That doesn’t block migrating the hook handlers from static methods to classes with ObjectFactory specs – the classes just don’t have an interface to implement yet. > > Also, the task description of T338452 <https://phabricator.wikimedia.org/T338452> sounds like it’s only for migrating the hook handlers Wikibase registers (for hooks from core or other extensions), which IMHO is quite separate from how Wikibase fires its own hooks. Technically the hook interfaces are not needed to use `HookHandlers` as the called method is build up by the hook name and not by the interface name, but the interfaces providing good documentation about types and arguments. Applying this along with the conversion brings better quality by using static analyzers and avoids later work to add them, which could be missed because it already works as is. The tasks about "new HookContainer/HookRunner" (including the #epic <https://phabricator.wikimedia.org/tag/epic/> parent task T263353 <https://phabricator.wikimedia.org/T263353>) are for both things of the new hook system, that includes the hook interfaces with the HookRunner to fire own hooks and to use the hook interfaces in the hook handlers by the called code. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Eihel, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
