Sarai-WMDE added a comment.
As Lucas mentioned, this is an unwanted consequence of the process of replacing legacy styling variables. My assumption was that, while the name of the variables was similar, their values weren't the same. I just found that to be correct and that we need to do two changes: 1. In line 469 <https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/969215/4/style.less#b469>, the right token to use would be `@background-color-progressive-subtle` (instead of @background-color-progressive). This will fix the contrast issue that now affects selected cells. 2. The same goes for line 584 <https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/969215/4/style.less#584>. This will return the splitter to its original color. Human error is very likely and understandable in these comprehensive replacement processes. Sorry for the oversight! Wishing we could rely on visual regression testing. TASK DETAIL https://phabricator.wikimedia.org/T350153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
