Lucas_Werkmeister_WMDE added projects: Wikidata Dev Team, wmde-wikidata-tech. Lucas_Werkmeister_WMDE added a comment.
In T266706#9412289 <https://phabricator.wikimedia.org/T266706#9412289>, @matmarex wrote: > @Lucas_Werkmeister_WMDE I'm sorry. I thought that this was a mostly abandoned component, as this task about it failing tests has been open for more than a year, and I've been annoyed by it causing test failures on my work. I won't do that again. Alright, thank you. Tainted Refs is somewhat in limbo at the moment, but the #wikidata_dev_team_quality_tools <https://phabricator.wikimedia.org/project/view/6750/> team is still responsible for it as far as I’m aware. (But I guess it shouldn’t go directly into their sprint board, so tagging all of #wikidata_dev_team <https://phabricator.wikimedia.org/tag/wikidata_dev_team/> for now.) In T266706#9412278 <https://phabricator.wikimedia.org/T266706#9412278>, @kostajh wrote: > It would be helpful to have a policy (or maybe there is one already?) about flaky tests. My understanding is that for more than one case of a non-deterministic failure of a test, it is reasonable to disable it alongside a phabricator task explaining the error, so that there is an audit trail and relevant teams could follow up on it later. The closest thing I’m aware of is the etiquette that tasks which consistently break gate-and-submit for more than one Wikimedia-deployed repository are automatically eligible for Unbreak Now! status. (But I’m not sure if that’s actually written down somewhere, so I hesitate to call it a “policy”.) I’m not aware of any hard-and-fast rule on flaky tests; if a task has been open for long enough without activity from the responsible team, I think it would be acceptable for someone else to upload a change disabling that test, and for a third developer to +2 that if there are no objections after a while. (But I would still expect that +2 to come from a separate person, even if some time had passed.) TASK DETAIL https://phabricator.wikimedia.org/T266706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, matmarex, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Reedy, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
