thiemowmde added a subscriber: thiemowmde.
thiemowmde added a comment.

The guessing algorithm must be in line with the formatter we use to make full 
round trips possible.
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/formatters/HtmlTimeFormatter.php#L80
A full round trip can be when a user copy-pastes a value (or transcribes it 
from an other browser window). Currently this does not survive.

The calendar model is never shown when the precision is month or less precise. 
We agreed that this is a good thing and should not be changed.

If a year <= 1581 is marked as Gregorian and a user copy-pastes this, it will 
magically turn into Julian, causing data-loss.

Next steps:

- Find out what the actual edge is. Some code did <= 1581, other code did < 
1583.
- Re-evaluate and possibly re-implement the logic from the old UI: 
https://github.com/wmde/ValueView/blob/0.2/src/experts/TimeValue.js#L66
- All relevant formatters must be changed to always show the calendar model if 
it's not identical to the auto-detected value.
- Implement auto-detection.

@Jc3s5h: Please report individual problems as individual tasks. I created 
https://phabricator.wikimedia.org/T98194 for the February 29 issue.


TASK DETAIL
  https://phabricator.wikimedia.org/T75272

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, thiemowmde
Cc: thiemowmde, Wikidata-bugs, Tobi_WMDE_SW, Jc3s5h, Lydia_Pintscher, aude



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to