Lucas_Werkmeister_WMDE added a comment.
We deployed PS1 of the debug code <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/989125/1/> on mwdebug2001 and null-edited eowiki:Perseo. The result was this logstash event <https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-1-7.0.0-1-2024.01.09?id=Rorw7YwBk70gu8GmX6xU>, with: name=currentUsages Q1062299#T, Q1062299#L.eo, Q12502038#T, Q12502038#L.eo, Q12502038#L.en, Q130832#S, Q130832#T, Q130832#C, Q130832#C.P1559, Q130832#C.P21, Q130832#C.P263, Q130832#C.P460, Q130832#C.P22, Q130832#C.P25, Q130832#C.P26, Q130832#C.P40, Q130832#C.P451, Q130832#C.P935, Q130832#C.P373, Q130832#C.P225, Q130832#C.P227, Q130832#C.P244, Q130832#C.P214, Q130832#C.P213, Q130832#C.P906, Q130832#C.P269, Q130832#C.P268, Q130832#C.P496, Q130832#C.P651, Q130832#C.P245, Q130832#C.P434, Q130832#C.P409, Q130832#C.P349, Q130832#C.P1015, Q130832#C.P1053, Q130832#C.P650, Q130832#C.P691, Q130832#C.P396, Q130832#C.P950, Q1351992#T, Q1351992#L.eo, Q142739#T, Q142739#L.eo, Q161582#T, Q161582#L.eo, Q166155#T, Q166155#L.eo, Q1705660#T, Q1705660#L.eo, Q184742#T, Q184742#L.eo, Q190582#T, Q190582#L.eo, Q23015925#L.eo, Q23015925#T, Q26296#T, Q26296#L.eo, Q31841846#T, Q31841846#L.eo, Q31841846#L.en, Q34201#T, Q34201#L.eo, Q3476559#T, Q3476559#L.eo, Q3476559#L.en, Q4826203#T, Q4826203#L.eo, Q4826203#L.en, Q5200183#T, Q5200183#L.eo, Q5200183#L.en, Q60619064#T, Q60619064#L.eo, Q60619064#L.en, Q6581097#T, Q6581097#L.eo, Q950523#T, Q950523#L.eo, Q130832#D.eo name=usages Q130832#T, Q130832#C, Q130832#S, Q6581097#T, Q6581097#L.eo, Q3476559#T, Q3476559#L.eo, Q3476559#L.en, Q34201#T, Q34201#L.eo, Q190582#T, Q190582#L.eo, Q161582#T, Q161582#L.eo, Q950523#T, Q950523#L.eo, Q1351992#T, Q1351992#L.eo, Q142739#T, Q142739#L.eo, Q26296#T, Q26296#L.eo, Q1705660#T, Q1705660#L.eo, Q166155#T, Q166155#L.eo, Q4826203#T, Q4826203#L.eo, Q4826203#L.en, Q5200183#T, Q5200183#L.eo, Q5200183#L.en, Q1062299#T, Q1062299#L.eo, Q60619064#T, Q60619064#L.eo, Q60619064#L.en, Q31841846#T, Q31841846#L.eo, Q31841846#L.en, Q23015925#L.eo, Q23015925#T, Q12502038#T, Q12502038#L.eo, Q12502038#L.en, Q184742#T, Q184742#L.eo and **newUsages empty** (presumably the empty //array//, though logstash doesn’t quite show that) and numNewUsages=0. So given that we believe `$newUsages` to be the empty array, the code should have returned early and not enqueued a job at all: name=DataUpdateHookHandler::onParserCacheSaveComplete() if ( $newUsages === [] ) { return; } $addUsagesForPageJob = AddUsagesForPageJob::newSpec( $title, $newUsages ); $this->jobScheduler->push( $addUsagesForPageJob ); And yet, we saw the job created in kafkacat: kafkacat -C -b kafka-jumbo1013.eqiad.wmnet:9092 -t codfw.mediawiki.job.wikibase-addUsagesForPage -o -100000 -e | grep -E 'eowiki|eo.wikipedia.org' | less {"$schema":"/mediawiki/job/1.0.0","meta":{"uri":"https://placeholder.invalid/wiki/Special:Badtitle","request_id":"9e0e2560-bae7-4857-beb4-32d1276062c2","id":"db1a7a9e-f511-405e-a8de-f5e55659af0f","dt":"2024-01-09T11:16:42Z","domain":"eo.wikipedia.org","stream":"mediawiki.job.wikibase-addUsagesForPage"},"database":"eowiki","type":"wikibase-addUsagesForPage","sha1":"8ad2a549a2258f3c839f81639c8f42eb6537b789","params":{"namespace":0,"title":"Perseo","pageId":115136,"usages":{"Q130832#C.P1559":{"entityId":"Q130832","aspect":"C","modifier":"P1559"},"Q130832#C.P21":{"entityId":"Q130832","aspect":"C","modifier":"P21"},"Q130832#C.P263":{"entityId":"Q130832","aspect":"C","modifier":"P263"},"Q130832#C.P460":{"entityId":"Q130832","aspect":"C","modifier":"P460"},"Q130832#C.P22":{"entityId":"Q130832","aspect":"C","modifier":"P22"},"Q130832#C.P25":{"entityId":"Q130832","aspect":"C","modifier":"P25"},"Q130832#C.P26":{"entityId":"Q130832","aspect":"C","modifier":"P26"},"Q130832#C.P40":{"entityId":"Q130832","aspect":"C","modifier":"P40"},"Q130832#C.P451":{"entityId":"Q130832","aspect":"C","modifier":"P451"},"Q130832#C.P935":{"entityId":"Q130832","aspect":"C","modifier":"P935"},"Q130832#C.P373":{"entityId":"Q130832","aspect":"C","modifier":"P373"},"Q130832#C.P225":{"entityId":"Q130832","aspect":"C","modifier":"P225"},"Q130832#C.P227":{"entityId":"Q130832","aspect":"C","modifier":"P227"},"Q130832#C.P244":{"entityId":"Q130832","aspect":"C","modifier":"P244"},"Q130832#C.P214":{"entityId":"Q130832","aspect":"C","modifier":"P214"},"Q130832#C.P213":{"entityId":"Q130832","aspect":"C","modifier":"P213"},"Q130832#C.P906":{"entityId":"Q130832","aspect":"C","modifier":"P906"},"Q130832#C.P269":{"entityId":"Q130832","aspect":"C","modifier":"P269"},"Q130832#C.P268":{"entityId":"Q130832","aspect":"C","modifier":"P268"},"Q130832#C.P496":{"entityId":"Q130832","aspect":"C","modifier":"P496"},"Q130832#C.P651":{"entityId":"Q130832","aspect":"C","modifier":"P651"},"Q130832#C.P245":{"entityId":"Q130832","aspect":"C","modifier":"P245"},"Q130832#C.P434":{"entityId":"Q130832","aspect":"C","modifier":"P434"},"Q130832#C.P409":{"entityId":"Q130832","aspect":"C","modifier":"P409"},"Q130832#C.P349":{"entityId":"Q130832","aspect":"C","modifier":"P349"},"Q130832#C.P1015":{"entityId":"Q130832","aspect":"C","modifier":"P1015"},"Q130832#C.P1053":{"entityId":"Q130832","aspect":"C","modifier":"P1053"},"Q130832#C.P650":{"entityId":"Q130832","aspect":"C","modifier":"P650"},"Q130832#C.P691":{"entityId":"Q130832","aspect":"C","modifier":"P691"},"Q130832#C.P396":{"entityId":"Q130832","aspect":"C","modifier":"P396"},"Q130832#C.P950":{"entityId":"Q130832","aspect":"C","modifier":"P950"}},"requestId":"9e0e2560-bae7-4857-beb4-32d1276062c2"},"mediawiki_signature":"3e62429ff1d741b8a7ab994f97dd86ba141dea50"} We have no idea how the job could have been created, and will add even more debug logging around that early return. TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, hoo, Lucas_Werkmeister_WMDE, ItamarWMDE, Ladsgroup, Krinkle, eprodromou, aaron, Michael, Aklapper, thcipriani, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
