Lucas_Werkmeister_WMDE added a comment.
In T305660#9452899 <https://phabricator.wikimedia.org/T305660#9452899>, @ArthurTaylor wrote: > After removing the (used) OPTION_USE_OBJECTS_FOR_MAPS (per T353626 <https://phabricator.wikimedia.org/T353626>), I looked at what it would mean to just apply OPTION_USE_OBJECTS_FOR_EMPTY_MAPS change globally (and thereby simply eliminate the need for the option). The effect of making the change globally is that some tests fail <https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/146055/console> because of interactions with the ApiResult serialization. > > To avoid making global changes to the way we serialize objects, my preference would be to use the flag - it seems like too large a can of worms to open to address such a minor serialization issue. I see, that’s unfortunate. In the long term, I feel like it would be better for the serializers to directly return all the information they can (not just objects for all maps, but even the extra metadata that’s currently tacked on in `ResultBuilder::getEntitySerializationWithMetaData()`), and for later parts of the stack to strip out the metadata they don’t need again – but that would be a lot more effort. Let’s just limit this option to the dumps for now, then. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: Milimetric, ArielGlenn, BTullis, xcollazo, JEbe-WMF, Mohammed_Sadat_WMDE, Masssly, Michael, Arian_Bozorg, Pintoch, Lucas_Werkmeister_WMDE, Ivan_A_Krestinin, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Stevemunene, Adamm71, Jersione, Hellket777, LisafBia6531, Busfault, Astuthiodit_1, Atieno, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, jannee_e, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, holger.knust, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Lunewa, Mahir256, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, gnosygnu, Wikidata-bugs, aude, Mbch331, Hokwelum
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
