Sarai-WMDE created this task. Sarai-WMDE added projects: Wikidata Dev Team, Wikidata.org. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Problems -------- The close (X) button in the top right corner of the onboarding popup used to provide extra information about the Default values feature overlaps with its text content. F41691246: Screenshot 2024-01-12 at 15.48.27.png <https://phabricator.wikimedia.org/F41691246> On the other hand, there's insufficient space between the "don't show this again" checkbox and the popover's bottom margin. Expected outcome ---------------- Elements in the popover heading should present the right padding and not overlap. - There should be a space of at least 4px between the title and the button on desktop, and 8px on mobile ([[ h[[ URL | name ]]ttps://www.figma.com/file/UMHGYSxln03lGx2z7GxzP2/Multiple-languages?type=design&node-id=546-4970&mode=design&t=WHULkLHxVKjhhZvx-0 | see specifications ]]). - There should be a margin of 8px between the popover checkbox and the bottom border | Check Figma specs <https://www.figma.com/file/UMHGYSxln03lGx2z7GxzP2/Multiple-languages?type=design&node-id=546-4970&mode=design&t=WHULkLHxVKjhhZvx-0> or OOUI demo <https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#demo-section-popupButton> for reference | | Acceptance criteria ------------------- [ ] The close button, used to dismiss the onboarding popover, doesn't overlap with the text included in the popover's heading [ ] There's sufficient spacing between the "Don't show this again" popover checkbox and the component's bottom margin TASK DETAIL https://phabricator.wikimedia.org/T355059 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, ItamarWMDE, KimKelting, Wikidata-bugs
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
