thiemowmde added a comment. - I would like to see an external reference for the "grouping vs. selecting" statement. - I still don't see a problem with "consistency in this [the `StatementList`] class". There is no other occurrence of "ByGuid" or "WithGuid". - I picked the name for consistency with `StatementByGuidMap::getStatementByGuid`. - "WithGuid" occurs 5 times in DataModel code, 3 times in the deprecated `Claims` class we are phasing out right now. - "ByGuid" occurs 9 times in code and comments.
TASK DETAIL https://phabricator.wikimedia.org/T98180 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: JeroenDeDauw, Bene, thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
