Sarai-WMDE added a subscriber: guergana.tzatchkova. Sarai-WMDE added a comment.
All AACCs are met and no spacing alteration were detected, so the task can be considered done. I need a little help to make a decision regarding the following: As part of this tak, all WiKit tokens were replaced by the new variables, but there are still some discrete spacing values in `rem` and `em` units in app.scss (lines 75 to 84 <https://github.com/wmde/wikidata-mismatch-finder/pull/794/files#diff-b339140a5abe2cafdc4e45227556c9b8799da604d97644e62f472d5f80506725R75>, line 234 <https://github.com/wmde/wikidata-mismatch-finder/pull/794/files#diff-b339140a5abe2cafdc4e45227556c9b8799da604d97644e62f472d5f80506725L234>...). The different token replacement tasks indicate (see "Considerations") that discrete values should also be replaced by Codex tokens, but this wasn't listed as an acceptance criterion. Our files still contain discrete values of all sorts (spacing, color, sizes, etc), so my question is: should I create a separate task to replace all the pending discrete values that require so, or should we tackle these as part of the existing tasks? What is your preference @noarave, @guergana.tzatchkova, @HasanAkgun_WMDE? TASK DETAIL https://phabricator.wikimedia.org/T350189 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: guergana.tzatchkova, HasanAkgun_WMDE, Arian_Bozorg, ItamarWMDE, karapayneWMDE, Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
