Lucas_Werkmeister_WMDE added a comment.
Looking at logstash, the sense version of this error seems to be somewhat more common (which is annoying since we only added logging to the form version), but there’s still a couple of occurrences in logstash, such as this one <https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-1-7.0.0-1-2023.12.26?id=nZ9Tp4wBFe9MHf51B3Mj> (`reqId:"4c2aaeea-5a28-4d57-afa8-47f447afed52"`; `@timestamp` Dec 26, 2023 @ 18:11:25.115). - formId: L679512-F3 (was removed <https://www.wikidata.org/w/index.php?title=Lexeme:L679512&diff=prev&oldid=2037663877>, incidentally by the same user as in T326768#8523696 <https://phabricator.wikimedia.org/T326768#8523696>, but with a revision timestamp three minutes before the logstash timestamp) - representationDiff: `a:4:{s:4:"data";a:0:{}s:5:"index";i:0;s:12:"typePointers";a:6:{s:3:"add";a:0:{}s:6:"remove";a:0:{}s:6:"change";a:0:{}s:4:"list";a:0:{}s:3:"map";a:0:{}s:4:"diff";a:0:{}}s:5:"assoc";s:1:"n";}` - grammaticalFeaturesDiff: `a:4:{s:4:"data";a:0:{}s:5:"index";i:0;s:12:"typePointers";a:6:{s:3:"add";a:0:{}s:6:"remove";a:0:{}s:6:"change";a:0:{}s:4:"list";a:0:{}s:3:"map";a:0:{}s:4:"diff";a:0:{}}s:5:"assoc";s:1:"n";}` - statementsDiff: `a:4:{s:4:"data";a:0:{}s:5:"index";i:0;s:12:"typePointers";a:6:{s:3:"add";a:0:{}s:6:"remove";a:0:{}s:6:"change";a:0:{}s:4:"list";a:0:{}s:3:"map";a:0:{}s:4:"diff";a:0:{}}s:5:"assoc";s:1:"t";}` - existingForms: L679512-F1, L679512-F2, L679512-F4, L679512-F5 All three diffs are effectively just empty, and in fact they’re almost identical. Unserialized, they look like this: [ "data" => [], "index" => 0, "typePointers" => [ "add" => [], "remove" => [], "change" => [], "list" => [], "map" => [], "diff" => [], ], "assoc" => "n", ] Where the `statementsDiff` has `"assoc" => "t"` instead of `"n"`. So we’ve ended up with a `ChangeFormDiffOp` for a form that should already be deleted, with no visible changes for that form. (Though it might be worth checking whether the diff contains any other `$this->diffOps`?) It might also be worth logging (or getting from Hive, like in T255566#9484983 <https://phabricator.wikimedia.org/T255566#9484983>?) the request parameters, so we know which request this error comes from. (And if we’re adding more logging, we should definitely also add it to the senses code, so we have more chances of seeing the problem.) TASK DETAIL https://phabricator.wikimedia.org/T326768 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: thiemowmde, Lucas_Werkmeister_WMDE, ItamarWMDE, Michael, Aklapper, jeena, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
