noarave added a comment.

  Expanding on one of the comments I added in the report for documentation 
purposes:
  
  The Gitlab Migration Guide 
<https://www.mediawiki.org/wiki/GitLab/Hosting_a_project_on_GitLab#Migrating_a_project>
 specifies:
  
  > "This will create a complete copy of the repository, including all branches 
and review notes from Gerrit."
  
  ("This" being importing the project to Gitlab by URL).
  
  I spent some time looking through projects already ported to Gitlab (see list 
of repos in miscweb <https://gitlab.wikimedia.org/repos/sre/miscweb>) and I 
couldn't find evidence that review notes are migrated as well. 
  For example, see this change on Gerrit 
<https://gerrit.wikimedia.org/r/c/wikimedia/TransparencyReport/+/427568> and 
its migrated equivalent on Gitlab 
<https://gitlab.wikimedia.org/repos/sre/miscweb/transparencyreport/-/commit/4aad4a8406935072d4f4bfdcfea827c00b69ee95?view=inline>.
 In this case the final commit was migrated, but the previous commits in the 
Gerrit patch and the review notes for those commits have not been included and 
are nowhere to be found in the Gitlab migrated project.
  
  It might be worth to at least find out what the Gitlab team's approach to 
this is. The review data isn't lost, it's still on Gerrit and will probably 
remain there until the foundation stops using Gerrit altogether which I don't 
see happening any time soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T350705

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, noarave
Cc: noarave, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Nintendofan885, Akuckartz, brennen, 
Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, TerraCodes, _jensen, rosalieper, Scott_WUaS, thcipriani, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to