Lucas_Werkmeister_WMDE added a comment.
Hm, this comes back to an annoyance I had noticed in T345064 <https://phabricator.wikimedia.org/T345064> – `EntityRedirectCreatorInteractor` wants to throw `RedirectCreationException` on error, but `RedirectCreationException` automatically prepends all error message keys with `'wikibase-redirect-'`. So if the `TempUserCreator` fails to create a temporary user, I can’t just forward its error message – I have to create a new message like `wikibase-redirect-cant-redirect-due-to-tempusercreator-error` or whatever. This is quite annoying and causes unneeded extra work for our volunteer translators. If we used the MediaWiki `Status` pattern instead, we could cleanly return messages with arbitrary message keys (and even with parameters!), and forward any bad `Status` returned by the `TempUserCreator`. IMHO it’s worth making this change first. TASK DETAIL https://phabricator.wikimedia.org/T356149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
