Umherirrender added a comment.

  In T353161#9523476 <https://phabricator.wikimedia.org/T353161#9523476>, 
@cscott wrote:
  
  > This dynamic property is causing spurious failures in phan as well, when 
phan randomly "gets smart enough" to notice that the Title class doesn't 
actually have a property named `wikibasePushedDeleteToRepo`.  See 
https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/96606/console 
for example.
  
  With the remove of the `DeprecationHelper` trait in 
7fc8d800b78e4d3d49cdadc686310485607072fe 
<https://phabricator.wikimedia.org/rMW7fc8d800b78e4d3d49cdadc686310485607072fe> 
there is no `Title::__set` or `Title::__get` and phan is now strict about the 
undeclared properties resulting in this report (Before phan could not infer the 
result of __set/__get to report every undeclared property directly).
  It should not be randomly, that mostly seen in the context of taint-check, 
where the order of class loading can impact the result.

TASK DETAIL
  https://phabricator.wikimedia.org/T353161

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Umherirrender, Aklapper, 
Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to