Lucas_Werkmeister_WMDE added a comment.

  In T353961#9595926 <https://phabricator.wikimedia.org/T353961#9595926>, 
@kostajh wrote:
  
  > Thanks. I added T359043 <https://phabricator.wikimedia.org/T359043> as a 
parent task, assuming that this task is also about fixing the CI errors when 
AutoCreateTempUser is enabled. The three errors I see (log 
<https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php74-docker/39519/consoleFull>):
  
  Those are the same three I saw, yes.
  
  In T353961#9595936 <https://phabricator.wikimedia.org/T353961#9595936>, 
@Daimona wrote:
  
  > Ideally, I think addDBDataOnce should be treated as a "seeding" method. You 
use it to define the initial state of the database for the test class, **and 
the database is brought back to that state after every test.**
  
  (Emphasis added.) Heh, I was about to write something similar ^^ but 
unfortunately, I assume some tests rely on having outer transaction scope, so 
we probably can’t implement this with a transaction in 
`MediaWikiIntegrationTestCase`. It would probably be possible by copying the 
affected tables around, but that might be prohibitively slow :(

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to