Arian_Bozorg created this task. Arian_Bozorg added projects: Wikidata Dev Team, Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Problem ------- The layout, typography and custom elements that –together with WiKit components – make up Query Builder's UI were styled (in most cases) using WiKit tokens. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the now official Wikimedia design system. WiKit tokens will be deprecated together with the legacy system, and thus their use is not advised. Solution -------- We need to import Codex tokens and use them to replace the WiKit tokens (of all global, aliases and component types) that were used to style Query Builder. This will take us a step closer to switching to the new design system and deprecating the old. Here's a list of WiKit tokens and their equivalent Codex styles <https://docs.google.com/spreadsheets/d/1CmrW7JVt9o2TvAfyIVScOE_Vc1h8DLpBqvsVhAB84kU/edit#gid=1602375525>. Considerations -------------- - Layout and Spacing styles: Unfortunately, `$dimension-layout` tokens (which have `rem` values) and `$dimension-spacing` (which use `em` values) do not have an equivalent style in Codex. We'll need to use custom variables to replace these (see T346261 <https://phabricator.wikimedia.org/T346261>) - The task's goal is to replace WiKit tokens in use in the Query Builder app's Sass files. Nevertheless, we should consider the stretch goal of improving the token coverage by replacing discrete values too, if detected. - We'll have to recreate/replace _typography.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/_typography.scss> and instead use Codex tokens. Acceptance criteria ------------------- [ ] All the WiKit tokens used to style the Query Builder app that have an equivalent in Codex are replaced [ ] WiKit tokens used to style the Query Builder app that don't have an equivalent in Codex are replaced by custom variables TASK DETAIL https://phabricator.wikimedia.org/T359864 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Aklapper, Sarai-WMDE, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
