Tacsipacsi added a comment.
In T310581#9660648 <https://phabricator.wikimedia.org/T310581#9660648>, @Lucas_Werkmeister_WMDE wrote: > Apparently @cscott recently added toBcp47Code() <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/983271>, but as a non-static instance method. I’ve already used it <https://www.wikidata.org/w/index.php?title=Module:Wikidata_label/sandbox&diff=2109754235>, forgetting about the fact that it supposedly doesn’t exist. 🙂 > I think the expensiveness argument from earlier needs to be reevaluated anyway, though, in light of T342418: Speed up Language creation <https://phabricator.wikimedia.org/T342418> – both creating a language and looking up its RTL flag should be fast now, as far as I’m aware. (But I don’t know if Scribunto was updated for that or if it still includes it in the expensive function count.) Creating a new language object is not an “expensive parser function” as tracked by the core parser (I don’t know if it has ever been one, but definitely wasn’t when I wrote T310581#8002337 <https://phabricator.wikimedia.org/T310581#8002337>). It uses a separate counter, which still defaults to 30, but has been 200 in WMF production since T85461 <https://phabricator.wikimedia.org/T85461>. TASK DETAIL https://phabricator.wikimedia.org/T310581 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tacsipacsi Cc: Izno, cscott, mxn, Zebulon84, Tacsipacsi, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, S8321414, mrephabricator, LennardHofmann, Astuthiodit_1, MaryMunyoki, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, srishakatux, KimKelting, LawExplorer, SundanceRaphael, _jensen, rosalieper, Scott_WUaS, Nikki, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
