JMeybohm added a comment.

  In T362084#9700057 <https://phabricator.wikimedia.org/T362084#9700057>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Can someone clarify what the problem here is? From WBQC’s perspective, it’s 
totally expected that some of these regex checks will fail (though there’s some 
confusion about which shellbox errors we should or shouldn’t try to catch, see 
T304084 <https://phabricator.wikimedia.org/T304084> and especially 
T304084#8561863 <https://phabricator.wikimedia.org/T304084#8561863>). But we 
might need to make some changes to keep the service mesh monitoring happy? 
(“exceeding retry limit” also sounds concerning – we don’t really want these 
requests to be retried, I think.)
  
  The reason I've opened the task is that the stream of errors/retries it 
looked fishy and I wanted to make sure we have an understanding of what is 
going on. From my naive POV I would argue that a preg_match error should not be 
classified as a an internal server error, as it results from (invalid) user 
input. If this is the desired response in that case, we should probably, as you 
said, configure the service-mesh to not retry requests on 500 errors - as that 
does not make any sense then.

TASK DETAIL
  https://phabricator.wikimedia.org/T362084

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JMeybohm
Cc: Lucas_Werkmeister_WMDE, Reedy, akosiaris, Clement_Goubert, JMeybohm, 
Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Kappakayala, 
Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Arnoldokoth, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
wkandek, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Eihel, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, 
jijiki, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Verdy_p, abian, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to