thiemowmde added a subscriber: thiemowmde. thiemowmde added a comment. We just discussed in https://phabricator.wikimedia.org/tag/wikidata-sprint-2015-06-02/ that people should make explicit what they think. So here we go:
I'm sorry to say that, but the problem description does not enlighten me much. What I read here is that having a generic Lib directory is not good. But the question why exactly is not answered. And won't this problem be the exact same with the proposed "Toolkit" component? From what I read here the two kinds of problems described later don't get better with the proposed component: - Global state can be avoided. Stuff that breaks boundaries can be fixed. Stuff depending on things in Client or Repo can be fixed. - It's still not obvious to me how replacing a Lib directory with a "Toolkit" component makes responsibilities more obvious. The set of rules sounds good. There is enlightenment. Thanks for that. However, the resulting component still feels like a "Lib2" folder to me, just with some more strict boundaries (basically: you are not allowed to pull in dependencies). This really is not much more but a generic "Wikibase DataModel Services" component. My personal conclusion: Let's do it. I think it's making the situation better. We may need to move classes again later, but this is not much worse than what we currently do. I agree on the "wait for DataModel 4.x" suggestion. TASK DETAIL https://phabricator.wikimedia.org/T93741 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Tobi_WMDE_SW, Lydia_Pintscher, adrianheine, JeroenDeDauw, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
