Sumit added a comment.

I tried this exhaustively with a number of images and mostly it returns an 
error:

> Fatal error: Call to a member function getUrl() on a non-object in 
> /vagrant/mediawiki/extensions/WikidataPageBanner/includes/WikidataPageBanner.hooks.php
>  on line 123


However sometimes, there's no error.
The only possible reason I can find for this is that the method 
WikidataPageBanner::getBannerUrl() is generating banners of 4 different widths 
and returning their urls and does this using api requests in case of a Foreign 
file. Its probable that "$mto->transform()" does not return on time and 
consequently the transformation result is null, which is the above error.
A probable solution in case of a foreign file is to load a small default image 
and generate the full srcset on client-side using javascript.


TASK DETAIL
  https://phabricator.wikimedia.org/T101565

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to