daniel added a comment. In https://phabricator.wikimedia.org/T101752#1350742, @JeroenDeDauw wrote:
> > 3rd party wikis using Wikidata items as unit identifiers. > > > Can you be more specific? I'm guessing you are talking about third party > wikis running a Wikibase Repository, and have items in there with entityid > datavalues pointing to Wikidata? Yes, in EntityIdValues, but also as unit URI in QuantityValue, calendar URI in TimeValue, and globe URI in GlobeCoordinateValue. > > I see no breaking change nor a contract change. > > > Will all code that currently works with an EntityId do the correct thing when > it gets such an instance of this new derivative? I don't think so. Code that uses getNumericId will break. The assumption that getNumericId exists is invalid,, but still made in some parts of the code. Other than that, I can't think of any issues. EntityId is completely opaque. In https://phabricator.wikimedia.org/T101752#1352159, @mkroetzsch wrote: > I would suggest to use this and to store pairs <sitekey,localEntityId> and to > have the URI prefix stored in the sites table. It's cleaner than storing the > actual URI string (which might change if an external site is reconfigured!) > in the actual values on the page. Cool URIs never change :) Yes, I have been thinking about this too. May be an option, not quite sure yet. > A strategy for introducing this without breaking anything much is to keep the > local wikis sitekey as the default setting in all cases. So callers who are > not aware of the external site support can keep sending "local" ids and will > get the right thing. Only when they read data they will have to mind the new > information (but that's always the case if you enable linking to external > entities). That was the idea, yes. TASK DETAIL https://phabricator.wikimedia.org/T101752 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: mkroetzsch, JeroenDeDauw, Aklapper, daniel, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
