thiemowmde added a comment. Had a chat with @Snaterlicious. We found that @adrianheine's comments in https://gerrit.wikimedia.org/r/#/c/190799/8/view/resources/jquery/wikibase/jquery.wikibase.statementview.js are relevant.
- Current situation is that the widget requires a ClaimsChanger and a EntityChangersFactory. Which is odd in itself. - ClaimsChanger is obvious, it's used to edit the main snak. - EntityChangersFactory has no use other than asking for a ReferencesChanger. - We agreed that this should be changed in a separate patch: EntityChangersFactory should be removed and replaced with a ReferencesChanger. This refactoring alone will make parts of https://gerrit.wikimedia.org/r/190799 redundant. This could also be done the other way around (use EntityChangersFactory for both) but we agreed that it's better to have options that are as specific as possible, not a factory that's as generic as the EntityChangersFactoryis. - The reason why @Snaterlicious made the new option optional is that he wanted to the widget to be cross-compatible with the old and the new mode. We agreed that this should be done with a boolean option instead. TASK DETAIL https://phabricator.wikimedia.org/T87759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: matej_suchanek, gerritbot, Tobi_WMDE_SW, Aklapper, Snaterlicious, thiemowmde, adrianheine, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
