thiemowmde added a comment. - Parsers and lookups and such are obviously much closer to "services" than they are to a "model". - ByPropertyIdGrouper: I always found this class weird. It could even be rewritten to pass id serialization strings instead of EntityId objects. With this simple change the class would be completely independent from everything. It would have literally **no** dependencies. So yes, please move or even remove. - LegacyIdInterpreter is closely bound to the two base entity types. It's an other way to call the Item and Property constructors. One could argue that this classifies as a "service". I think it should stay in DataModel or be removed completely. - PropertyIdProvider: Not a service. Useful when you do not want to bind against https://phabricator.wikimedia.org/tag/wikibase-datamodel-services/. So https://phabricator.wikimedia.org/tag/wikibase-datamodel/ please. - StatementGuidParser: I do not like the idea of having the code that constructs these GUIDs in one component and the code that can deconstruct them in an other. This means the knowledge about the internal structure of these GUIDs is split (and possibly duplicated) across two components.
TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: hoo, Tpt, thiemowmde, Addshore, Bene, JeroenDeDauw, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
