daniel added a comment.

The index names are off:

  CREATE INDEX /*i*/wbqc_constraints_pid_index
  ON /*_*/wbqc_constraints (pid);

is redundant, it should be

  CREATE INDEX /*i*/pid
  ON /*_*/wbqc_constraints (pid);

on mysql, this will create a pid index on the wbqc_constraints table. On 
SqlLite, /*i*/ will expand to the table name, making the index name unique, 
resulting in an index called wbqc_constraints_qid, which is what we want. The 
current code creates an index called 
`wbqc_constraints_wbqc_constraints_pid_index`, which seems a bit silly.

Index names are pretty irellevant, unless you use FORCE INDEX somewhere. In 
that case, make sure to get it right...


TASK DETAIL
  https://phabricator.wikimedia.org/T102992

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: jcrespo, Tamslo, csteipp, Springle, hoo, Aklapper, daniel, Wikidata-bugs, 
aude, GWicke, Krenair, Malyacko, P.Copp



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to