Legoktm added a subscriber: Legoktm. Legoktm added a comment. Quick code review:
- Configuration settings should be prefixed, a name like `$wgStandardSizes` is too general. - Should use extension.json - https://www.mediawiki.org/wiki/Manual:Extension_registration - !defined( 'MEDIAWIKI' ) check not needed unless you plan to support pre-MW 1.24 - This is adding a new parser function, has it been reviewed by Parsoid/VE teams? - Shouldn't call `OOUI\Theme::setSingleton` directly. - There are some hacks to work around TOC generation, this should probably be blocked on https://phabricator.wikimedia.org/T105520? - Use "self::" instead of "static::" unless necessary - `ext.WikidataPageBanner` has a dependency upon oojs-ui, but it's a style only module? TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm Cc: Legoktm, csteipp, kaldari, Ricordisamoa, Krenair, Sumit, Nicolas_Raoul, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
