Jdlrobson added a subscriber: matmarex. Jdlrobson added a comment. In https://phabricator.wikimedia.org/T98029#1472248, @Legoktm wrote:
> Quick code review: > > - Configuration settings should be prefixed, a name like `$wgStandardSizes` > is too general. >T106586 ======== > - Should use extension.json - > https://www.mediawiki.org/wiki/Manual:Extension_registration > T106587 ========= > - !defined( 'MEDIAWIKI' ) check not needed unless you plan to support pre-MW > 1.24 I'm not sure whether this support is needed. I will leave it to @sumit to decide. > - This is adding a new parser function, has it been reviewed by Parsoid/VE > teams? Have cc'ed @ssastry to take a look. > - Shouldn't call `OOUI\Theme::setSingleton` directly. Could you elaborate on proper usage here? Are there any docs which provide best usage? (Note I did ask @matmarex to review this) > - There are some hacks to work around TOC generation, this should probably be > blocked on https://phabricator.wikimedia.org/T105520? Maybe... would be great if you could chip in on that bug, if there are any reasons, it is the way it is, but I don't personally think this needs to block deployment. > - Use "self::" instead of "static::" unless necessary From what I remember there were some problems getting the unit tests to pass with the mocks @sumit was using whilst using self. @sumit maybe you could post a patch changing back to self:: to see if we can debug that problem? > - `ext.WikidataPageBanner` has a dependency upon oojs-ui, but it's a style > only module? oojs-ui-styles is probably the answer =>https://phabricator.wikimedia.org/T106588 TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: matmarex, ssastry, Legoktm, csteipp, kaldari, Ricordisamoa, Krenair, Sumit, Nicolas_Raoul, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
