JeroenDeDauw added a subscriber: JeroenDeDauw. JeroenDeDauw added a comment.
I think it'd have been better if this was phrased as "create means to construct an EntityDiffer", which does not already decide on a specific approach. As far as I can tell, there is no need for this at all. What would such a factory class do? Just have the entity differ be constructed in the appropriate DI system (ie the WikibaseRepo class). Furthermore, even though `Entity::getDiff` was deprecated, it did have a replacement. Which is what you should use now, as `Entity::getDiff` has been removed already. TASK DETAIL https://phabricator.wikimedia.org/T106308 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeroenDeDauw Cc: JeroenDeDauw, daniel, Aklapper, Ladsgroup, Wikidata-bugs, aude, Malyacko, P.Copp _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
