JeroenDeDauw added a comment. Thanks for the feedback Thiemo. Unfortunately I've already merged `TypedValueFormatter` and `ValuesFinder` now, as there where no objections on the PRs and I had not seen this. No real damage done as no release has happened yet. Let's discuss them and revert if needed.
> Mixed feelings about ValuesFinder. Could also go in DataValues. It can't - it uses `PropertyDataTypeLookup` which is in DM Services and `PropertyId` which is in DM > Disagree on TypedValueFormatter. This belongs to DataValues. When I looked at it at first, I had a similar reaction. After all, this class does not strictly speaking depend on DM, so it seems to not match the contract of DM Services. .... #fail. Ok, I agree now this does not belong in this component. I mistakingly identified `$dataTypeId` as DM concept. And since it is not, this class indeed does not match the components contract of residence :) TASK DETAIL https://phabricator.wikimedia.org/T108286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeroenDeDauw Cc: Addshore, Bene, Tpt, hoo, thiemowmde, daniel, Jonas, aude, JeroenDeDauw, Aklapper, Wikidata-bugs, Malyacko _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
