JanZerebecki added a subscriber: JanZerebecki. JanZerebecki added a comment.
> It makes the code error prone because methods depend on a non-obvious side > effect. That methods change their hidden argument $this is why they are called methods. So unless you want to object to using methods in general... > It's a possible performance issue because it possibly clones big arrays and > allocates space. No, because PHP does COW. Just make sure to unset it when the deserializer is done, though that is probably a negligible memory improvement compared to other things. Thus, removing https://phabricator.wikimedia.org/tag/performance/. As I don't object to this in principle, it is just won't improve performance as described here. TASK DETAIL https://phabricator.wikimedia.org/T98124 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: JanZerebecki, JeroenDeDauw, thiemowmde, Aklapper, Wikidata-bugs, aude, GWicke _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
