thiemowmde added a comment. Is this ticket about the deprecation, about removing remaining usages of this class or about removing the class? These are three independent task. The first is long done since https://phabricator.wikimedia.org/tag/wikibase-datamodel/ 1.0. The second needs time. I disagree with the last needing a ticket.
About the usages, there is not much left, according to my local code base: - `Item` and `Property` still have `setClaims` methods. To be removed in https://github.com/wmde/WikibaseDataModel/pull/556. - Note: `getClaims` never returned a Claims object. - `ByPropertyIdArrayTest` uses Claims internally, but can easily be reworked. I wonder why this was not done yet. Could be that I lost track of all the open https://phabricator.wikimedia.org/tag/wikibase-datamodel/ pull requests, most of them being breaking changes now. Why not have a patch that refactors code without causing pain? - `StatementListTest` does have a test that it accepts a Claims object. TASK DETAIL https://phabricator.wikimedia.org/T78281 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Bene, thiemowmde, gerritbot, Aklapper, Lucie, Wikidata-bugs, aude, JeroenDeDauw _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
