thiemowmde created this task. thiemowmde added subscribers: thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, Jonas, adrianheine. thiemowmde added projects: Wikidata, DataValues, Easy, Patch-For-Review. Herald added a subscriber: Aklapper.
TASK DESCRIPTION `QuantityParser` does have code to accept a unit in two ways: in the input string and via an `unit` option. Most of this code exists since forever. Support for the option was added in https://github.com/DataValues/Number/pull/21 (T77981) and refined in https://github.com/DataValues/Number/pull/23 to properly handle conflicts between the input string and the option. If there is a conflict, the parser refuses to accept the input. All this is there and just works. It was always possible to enter "5 foo" and/or set the unit option to "foo" and the parser successfully turned this into `{ "amount": "+5", "unit": "foo", ... }` and passed it to the formatters and validators. Before https://gerrit.wikimedia.org/r/235512 (T111171) we never cared how these unit strings looked. They were just saved. This changed when we decided that units can not be arbitrary strings but must be URIs (with "1" being the only exception). But even at this point it was still not the job of the parser to decide if a string can be accepted as a unit or not. That's the job of the validator, which finally existed at this point and did not accept anything but wikidata.org concept URIs. But the parser was not updated accordingly and still accepted arbitrary strings but no URIs. This caused a series of actual issues: 1. The user could still type "5 foo" in the UI and the save button would be enabled, but when he hit save the unit was rejected by the validator because it now only accepts URIs. This was patched in https://github.com/DataValues/Number/pull/46 by simply removing that part of the parser's regex. 2. But when attempting to enter a valid URI the validator is fine with, the users input can not even make it that far. It's blocked by the parser because of the outdated regex. 3. At the same time the expert extender already allows copy-pasting concept URIs. So the user already can paste "5" and "http://www.wikidata.org/entity/Q1"; in two input fields but not "5 http://www.wikidata.org/entity/Q1"; in one input field. That's a bug as simple as it could be: QuantityParser must pass-through valid unit representations. There are literally no preconditions to allow this. The fact that units are URIs will never change. The fact that URIs start with http:// or https:// will most probably never change. Everything beyond that (most notably support for resolving "meter" and "m" into concept URIs) is unrelated and can be build on top of this without challenging the decision that the parser passes URIs through. Asking if we, as a team, want to allow users to work with concept URIs is like asking if a browser vendor wants to allow users to copy-paste URLs into the address bar. I refuse to accept this as an argument. Patches for review: * https://github.com/DataValues/Number/pull/37 * Number needs a new release then. * The release must be used. TASK DETAIL https://phabricator.wikimedia.org/T112082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: adrianheine, Jonas, daniel, Tobi_WMDE_SW, Lydia_Pintscher, thiemowmde, Aklapper, Wikidata-bugs, aude, 01tonythomas, MarcoAurelio _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
