JeroenDeDauw added a comment. > Those aren't important for the current RFC
I was under the impression the proposal was to have interfaces for all value objects (and presumably collections) in DataModel. If that is the case, we should consider the cost of changes to all of them. If not, then I'm rather concerned about making such disruptive changes for just part of the DataModel, forcing us to do more breaking of stuff as soon as we want another alternate implementation. > Yes, but fixing the tests should be very easy Do you see a difference between the tests and the production code? TASK DETAIL https://phabricator.wikimedia.org/T112893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, JeroenDeDauw Cc: daniel, Lydia_Pintscher, Aklapper, JanZerebecki, aude, Bene, JeroenDeDauw, thiemowmde, Jonas, Wikidata-bugs _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
