thiemowmde added a comment. > Shall I abandon https://gerrit.wikimedia.org/r/233934 then?
In my opinion, yes. At least for now. We caused quite some trouble and rebases to this point. Would be nice to focus on more productive stuff. Don't get me wrong, I'm thankful for what you did. The fact that an `if()` in JavaScript and an `if ()` in PHP always looked different always bugged me. In https://gerrit.wikimedia.org/r/242615 I collected a few more reasons for sticking with `function()`: - It's "official" in other JSCS presets, e.g. the "google" preset. - JSCS itself uses the "google" preset. - Even other big Wikimedia projects like Parsoid and Flow do it like we do. - MediaWiki core's PHP uses a mixture of `function()` and `function ()` with no clear preference and obviously no PHPCS set up to enforce anything. I find this relevant because I consider consistency across languages important. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Tobi_WMDE_SW, adrianheine, JanZerebecki, Ricordisamoa, gerritbot, Lydia_Pintscher, Addshore, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
