JanZerebecki added a comment. In https://phabricator.wikimedia.org/T113731#1686310, @mmodell wrote:
> CI should just check out all the submodules by following the submodule sha1 > references in the core branch, then it wouldn't matter how the branches are > named, ci would do the right thing by simply letting git do the right thing. That wouldn't fully cover what the CI does today, e.g. what would you do after uploading a patch to the repo mediawiki/extensions/Wikidata.git to a wmf branch? (There is an unfinished patch related to this: https://gerrit.wikimedia.org/r/#/c/161225/ ) Also there are other places besides CI where the same assumptions are baked in. Anyway, I would welcome improvements to the CI. > If CI isn't doing that now then it's a bug in the CI setup. It could also mean that how 3 extensions out of many are branched for wmf deployment violations the branching rules. Do you have an argument for why it should be more configurable than always matching branch names? The feature we tried by the patch didn't work as said in: https://phabricator.wikimedia.org/rMREL731742221ac2#inline-67 Later the following was discussed: <jzerebecki> twentyafterfour, hoo: no when the branch doesn't already exists it should copy from the previous one instead of master <twentyafterfour> jzerebecki: that would cause a proliferation of branches (which we already have everywhere else but I wish we didn't) <jzerebecki> twentyafterfour: i just want to make wikidata more like every other extension, having a deploy branch for every core deploy branch is a step. so if you change everything else to not proliferate... we could do that instead. <twentyafterfour> jzerebecki: I'm not too concerned either way but shouldn't we have the consensus of the wikidata team to make such a change? If you have already came to that decision then I'm fine with it, but make-wmf-branch is very inflexible and hard to fix so I need to know which way it should behave in order to fix the script <twentyafterfour> that is to say, I'd rather not fix it twice ;) <jzerebecki> twentyafterfour: that is the consens. I just rechecked with key people to make sure. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Wikidata-bugs, AndyRussG, Pcoombe, atgo, hashar, greg _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
