thiemowmde added a comment. All the extension does (besides the "pageimages" API module) is appending a page property called "page_image" for each page id to the `page_props` table, containing the pure file name without the namespace. (And it does that in a way that's not really applicable for our code base, by accessing `LinksUpdate::$mProperties`.) That's all. That's so simple, the only reason to bind to the https://phabricator.wikimedia.org/tag/pageimages/ extension is literally the constant `PageImages::PROP_NAME` with the "page_image" string. As far as I can see, not even major refactoring of the PageImages class would make it possible to reuse existing code.
I suggest to not bind against the PageImages extension but simply ... well, rely on `class_exists( 'PageImages' )`? To do: - What about the `wgPageImagesNamespaces` setting? Problem is, the PageImages extension should not work on Wikibase namespaces. But at the same time it would be confusing to have two separate settings for the same thing. - What about the `wgPageImagesBlacklist`? Our code should respect this. TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
