thiemowmde added a comment. I did regex searches for `new Class(` instantiations as well as static `Class::…(` calls in my local copy of the codebase, including all dependencies (ValueView, DataModel, all DataValues, and so on). I did not included other extensions like PropertySuggester or WikibaseQuality. I listed all usages no matter in which (sub) component they are. I tried to **highlight** what I think is a possible issue and should, for example, use a factory instead of creating an object directly.
- `AliasGroup` - Instantiations in production: AliasGroupList, AliasGroupListDeserializer, Fingerprint, LegacyFingerprintDeserializer - Usage in tests: 122 - `BasicEntityIdParser` - Instantiations in production: dumpEntities, EntityChange, SqlEntityInfoBuilder - Static calls in production: **WikibaseClient, WikibaseRepo** - Usage in tests: 75 - `ByPropertyIdArray` - Instantiations in production: ChangeOpStatement - Usage in tests: 0 - `Claims` - Usage: 0 - `DerivedPropertyValueSnak` - Usage: 0 - `DispatchingEntityIdParser` - Instantiations in production: BasicEntityIdParser, **WikibaseClient, WikibaseRepo** - Usage in tests: 0 - `EntityIdParsingException` - Instantiations in production: DispatchingEntityIdParser, ItemIdParser, **populateChangesSubscription**, SuffixEntityIdParser - Usage in tests: EntityIdDeserializerTest - `EntityIdValue` - Instantiations in production: EntityIdValueParser - Usage in tests: 44 - `EntityRedirect` - Instantiations in production: EntityContent, EntityContentDataCodec, EntityDataRequestHandler, RedirectCreationInteractor - Usage in tests: 52 - `HashableObjectStorage` - Usage: 0 - `ItemId` - Instantiations in production: BasicEntityIdParser, CachingSiteLinkLookup, createBlacklistedItems, DiffView, ExternalChangeFactory, HashSiteLinkStore, ItemHandler, ItemIdParser, LegacySiteLinkListDeserializer, MergeItems, ModifyEntity, SiteLinkListPatcher, SpecialPagesWithBadges, SpecialSetSiteLink, UpdateRepoJob, WikibaseLuaBindings - Static calls in production: ChangesSubscriptionTableBuilder, EntityPerPageTable, Item, LegacyIdInterpreter, SiteLinkTable, SiteLinkUniquenessValidator, SiteLinkUsageLookup - Usage in tests: 1034 - `ItemIdParser` - Usage: 0 - `ItemIdSet` - Instantiations in production: SiteLink - Usage in tests: SiteLinkListTest, SiteLinkTest - `Item` - Instantiations in production: createBlacklistedItems, GenericEntityInfoBuilder, Item, ItemContent, ItemDeserializer, ItemDiffer, ItemHandler, LegacyItemDeserializer, LinkTitles, SpecialNewItem - Usage in tests: 429 - `LegacyIdInterpreter` - Static calls in production: EntityContentDataCodec, EntityIdValue, EntityPerPageTable, LegacyEntityIdDeserializer, SqlEntityInfoBuilder, TermIndexEntry - Usage in tests: TermIndexEntryTest - `MapValueHasher` - Instantiations in production: HashableObjectStorage, HashArray, SnakList - Usage in tests: 0 - `PropertyId` - Instantiations in production: BasicEntityIdParser, ByPropertyIdArray, ByPropertyIdGrouper, CallbackFactory, changePropertyDataType, PropertyHandler, PropertyIdResolver, SnakObject, WikibaseRepo - Static calls in production: LegacyIdInterpreter, Property, PropertyInfoTableBuilder, SnakObject, SpecialListProperties, SqlEntityInfoBuilder - Usage in tests: 545 - `Property` - Instantiations in production: LegacyPropertyDeserializer - Static calls in production: importProperties, PropertyContent, PropertyDeserializer, PropertyHandler, SpecialNewProperty - Usage in tests: 114 - `PropertyNoValueSnak` - Instantiations in production: LegacySnakDeserializer, SnakDeserializer, SnakFactory - Usage in tests: 432 - `PropertySomeValueSnak` - Instantiations in production: LegacySnakDeserializer, SnakDeserializer, SnakFactory - Usage in tests: 110 - `PropertyValueSnak` - Instantiations in production: DerivedPropertyValueSnak, LegacySnakDeserializer, SnakDeserializer, SnakFactory - Usage in tests: 264 - `ReferencedStatementFilter` - Usage in production: 0 - Usage in tests: StatementListTest - `Reference` - Instantiations in production: LegacyStatementDeserializer, ReferenceDeserializer, ReferenceList, SetReference - Usage in tests: 143 - `ReferenceList` - Instantiations in production: **ClaimDiffer**, LegacyStatementDeserializer, ReferenceListDeserializer, Statement, StatementList - Usage in tests: 70 - `SiteLink` - Instantiations in production: DeletePageNoticeCreator, InfoActionHookHandler, LegacySiteLinkListDeserializer, LinkTitles, MovePageNotice, OtherProjectsSidebarGenerator, Runner, SiteLinkDeserializer, SiteLinkList, SiteLinkTable, SiteLinkUniquenessValidator, UpdateRepo, UpdateRepoOnMoveJob, WikibaseLuaBindings - Usage in tests: 155 - `SiteLinkList` - Instantiations in production: Item, LegacySiteLinkListDeserializer, LinkTitles, SetSiteLink, SiteLinkListPatcher - Usage in tests: 54 - `SnakList` - Instantiations in production: ClaimDiffer, LegacySnakListDeserializer, Reference, SnakListDeserializer, Statement, StatementList - Usage in tests: 144 - `StatementByGuidMap` - Usage: 0 - `StatementGuid` - Instantiations in production: StatementGuidParser - Usage in tests: StatementGuidParserTest - `Statement` - Instantiations in production: LegacyStatementDeserializer, StatementDeserializer, StatementGroupListView, StatementList - Usage in tests: 212 - `StatementList` - Instantiations in production: ChangeOpStatement, EntityChangeFactory, Item, LegacyItemDeserializer, Property, PropertyDiffer, ResultBuilder, StatementListDeserializer, StatementListPatcher - Usage in tests: 138 - `TypedSnak` - Usage in production: 0 - Usage in tests: SerializerFactoryTest, TypedSnakSerializerTest TASK DETAIL https://phabricator.wikimedia.org/T112893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Tobi_WMDE_SW, daniel, Lydia_Pintscher, Aklapper, JanZerebecki, aude, Bene, JeroenDeDauw, thiemowmde, Jonas, Wikidata-bugs, Mbch331 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
