Tobi_WMDE_SW added a comment. @adrianheine @janzerebecki I love to see movement in the direction of having a browsertest job running commit-wise, but I don't have an answer on the question whether it is good to move the tests to the Wikibase.git repository. One problem I see here is, that if you modify one of the JavaScript components, let's say ValueView, you would have to adjust the browser tests in Wikibase. Or, in case you break one of the tests with a change in ValueView, you would only notice the breakage on a change done in Wikibase.git (and in the worst case on an unrelated change in Wikibase.git).
TASK DETAIL https://phabricator.wikimedia.org/T118284 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Tobi_WMDE_SW Cc: daniel, adrianheine, gerritbot, Aklapper, Tobi_WMDE_SW, JanZerebecki, Jonas, Wikidata-bugs, aude, Mbch331, hashar, greg _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
