hoo added a comment.

So I looked into this, and found the root cause.

When Wikibase calls `EditFilterMergedContent` it uses `NewItem` (or 
`Item:NewItem`, depending on the namespace items are in) as title, because we 
don't have the Item Id at that point (because we don't want to assign Ids we 
never use, as edits might still fail).

When AbuseFilter chooses to tag an edit it does so by setting 
`AbuseFilter::$tagsToSet[$actionID] = array( /* TAGS */ );` where `$actionID` 
is `TITLE-USER-edit`. In `AbuseFilterHooks::onRecentChangeSave` that 
information is then used to save the change tags earlier assigned to that edit. 
That works by reproducing the above mentioned `$actionID` from the information 
present in the recent change entry.

Obviously that doesn't work for the Wikibase changes as the change tags are 
initially stored with the placeholder title, but the rc entries use the actual 
title.


TASK DETAIL
  https://phabricator.wikimedia.org/T106136

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: StudiesWorld, Sjoerddebruin, Bugreporter, aude, hoo, Addshore, Aklapper, 
Luke081515, matej_suchanek, Wikidata-bugs, Se4598, Jackmcbarn, Mbch331



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to