Bene added a comment. > I'm a bit worried about the contract of the existing method though.
I agree that this is not optimal for the reasons you pointed out. It would indeed be nicer if immutability could be provided. However, to achieve that we either have to make `TermList`, `StatementList` etc. immutable or we have to do a full object clone everytime we access the object which sounds quite expensive. > I'm not aware of which users you are trying to cater to, or what kind of > implementations you have in mind. It depends on these what the best solutions > are. The concrete users of these interfaces are the ones that currently use `FingerprintHolder`. We cannot longer bind terms to a fingerprint because not all entities have the combination a fingerprint provides (eg. the media type will only have labels and descriptions). Therefore, we need a way to tell a `LabelsProvider` that some label should change. TASK DETAIL https://phabricator.wikimedia.org/T126152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: daniel, JeroenDeDauw, thiemowmde, Aklapper, Bene, StudiesWorld, Izno, Wikidata-bugs, aude, Mbch331 _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
