daniel added a comment.

In https://phabricator.wikimedia.org/T121395#2008222, @aude wrote:

> @daniel hmm... Using the latest base revision would definitely help, though 
> wonder if relying on that, we still might have a race condition.


For two concurrent API requests, there is a race condition even if you do the 
check after the patch/merge. The only way to avoid this is to supply the 
//expected current revision// (the one we used for validation) when doing the 
actual saving. WikiPage has a mechanism for erroring out if the current 
revision was changed by a concurrent request. I'm afraid getting this right 
will require us to rewrite some of the logic in EditPage.


TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: thiemowmde, gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, 
Jonas, StudiesWorld, Izno, Wikidata-bugs, Mbch331



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to