daniel added a subscriber: daniel.
daniel added a comment.

Now happening to me with https://gerrit.wikimedia.org/r/#/c/270020/

  Starting test 
'Wikibase\Test\Interactors\TermIndexSearchInteractorTest::testSearchForEntities_returnsExpectedResults
 with 
  data set "Q111 Foo en Label match exactly" 
(Wikibase\Lib\Interactors\TermIndexSearchInteractor, array('Foo', 'en', 'item', 
  array('label')), array(array(Q111, Wikibase\DataModel\Term\Term, 'label')))'.
  
  Fatal error: String length exceeded 2^31-2: 2147483647 in 
/srv/deployment/integration/phpunit/vendor/phpunit/phpunit
  /PHPUnit/Framework/TestCase.php on line 1681

Line 1681 in TestCase.php:

  preg_match_all('/\n            \[(\w+)\] => Array\s+\*RECURSION\*/', 
print_r($data, TRUE), $matches);

Ugh, yea. $data is what the provider passes to the test function. If you have a 
service with a ton of dependencies in your $data, print_r is going to be HUGE. 
This is also SLOW!

We should make sure our data provides never pass complex objects. That's a 
shame really, it's quite convenient. Oh, well. I'll file a ticket.


TASK DETAIL
  https://phabricator.wikimedia.org/T70423

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Addshore, Krinkle, Wikidata-bugs, ori, aude, MaxSem, 
Lydia_Pintscher, Unknown Object (MLST), Izno, Mbch331



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to