Anomie added a comment.
> That change is good, but we need to improve the tests so they don't depend on configuration like this. +1. Why are you calling `Scribunto::newDefaultEngine()` in Scribunto_LuaWikibaseLibraryTest.php and Scribunto_LuaWikibaseEntityLibraryTest.php instead of using `$this->getEngine()`? That's bypassing all the work that Scribunto_LuaEngineTestBase does to have your code tested with both engines. TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Stashbot, gerritbot, Aklapper, aude, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, hashar, greg _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
