thiemowmde added subscribers: thiemowmde, Jonas, adrianheine, JanZerebecki, hoo, aude. thiemowmde claimed this task. thiemowmde edited projects, added Patch-For-Review, DataValues; removed Wikibase-DataModel. thiemowmde triaged this task as "Normal" priority. thiemowmde added a comment.
First draft: - https://github.com/DataValues/Number/pull/55 To be discussed: How should the serialization look like? - `{"amount":"+1","unit":"1","upperBound":"+2","lowerBound":"+0"}` is how it looks now when the user entered "1" and the parser guessed +/-1. - `{"amount":"+1","unit":"1","upperBound":null,"lowerBound":null}` is what my patch suggests. Advantage: Minimal breaking change because the keys are always there. Disadvantage: Wastes space. - `{"amount":"+1","unit":"1"}` is almost the same, but breaks consuming code faster. This could even be an advantage. - `{"amount":"+1","unit":"1","upperBound":"","lowerBound":""}` was mentioned today. I do not like this. Opinions? TASK DETAIL https://phabricator.wikimedia.org/T115270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: aude, hoo, JanZerebecki, adrianheine, Jonas, thiemowmde, StudiesWorld, Krenair, daniel, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331 _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
