Sjoerddebruin added a comment.

  In https://phabricator.wikimedia.org/T134097#2254479, @Ricordisamoa wrote:
  
  > Because of T108655: Standardise on how to access/register JavaScript 
interfaces <https://phabricator.wikimedia.org/T108655>, ResourceLoader closures 
have a `module` argument, causing files written for multiple environments like 
https://www.wikidata.org/wiki/MediaWiki:Gadget-PrimarySources-async.js to think 
they're running in Node.js instead of a browser. 
https://www.wikidata.org/wiki/?diff=328368494&oldid=308869398 should fix the 
bug.
  
  
  Thanks, that seems to fixed the issue. Can you also do a pull request on the 
GitHub project, to avoid introducing the error again? Also weird that this 
wasn't mentioned in the tech news.

TASK DETAIL
  https://phabricator.wikimedia.org/T134097

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ricordisamoa, Sjoerddebruin
Cc: Ricordisamoa, Josve05a, Sjoerddebruin, Aklapper, D3r1ck01, Izno, 
Wikidata-bugs, aude, Mbch331



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to